Capturing CTRL+D (EOF) to exit the shell #432
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
eubnara
commented
May 29, 2022
eubnara
commented
- support capturing CTRL+D to exit the shell
- add some tests for CTRL+C, CTRL+D cases
|
With spring shell v1.2.0, |
|
It's strange that |
jvalkeal
reviewed
May 30, 2022
| import org.jline.utils.AttributedStyle; | ||
| import org.junit.jupiter.api.Test; | ||
| import org.springframework.shell.ExitRequest; | ||
| import static org.junit.jupiter.api.Assertions.*; |
There was a problem hiding this comment.
@jvalkeal
Thanks for feedback!
I changed it to use assertj.
|
I currently use java 11.0.14 eclipse temurin installed by sdkman. |
|
I think this would be a good change and it did work when I ran a shell. We just can't merge it in this state as it jams a build. I briefly tried to debug it and it hangs on a thread somewhere inside jline classes. |
|
Great tests passes. I'll mark this to get merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.